Add --var-file-allowlist in server configuration #2362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 8, 2022
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new argument
--var-file-allowlistin server configuration to limit the access of variable definitions files on Atlantis server. Previously, we don't have such check so users can access arbitrary files that the Atlantis process has access to, with PR comments likeatlantis plan -- -var-file=/path/to/file.The default value of this argument is currently set to
--data-dir. This could be a breaking change since users who used to access files on Atlantis server outside of that directory need to pass in additional paths when running Atlantis. For users who only accessed files in repo directories, the behavior remains unchanged since files in the repo directory are still accessible as before.